mobile: use single webview & handle native/webview navigation ipc #3284
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
latter-bolden
changed the title
…s, store last messages/groups location
…ng to keyboard open/close, fix active tab stutter and misfires
latter-bolden
force-pushed
the
lb/mobile-webview-navigation
branch
from
79965b7
to
4a32e67
Compare
alecananian
reviewed
Feb 28, 2024
There was a problem hiding this comment.
Interesting approach! Looks to be working well - nice to not see loading spinners as I navigate around 🙂 I'm concerned about the fragility of all the state management and webview context, and it's hard to follow as a newcomer to the code. I think adopting a reducer pattern for that context could help a lot. I'd also like to see what the dev local mode is doing on your end - will schedule some time to walk through it with you.
…l with them blows up
|
@alecananian addressed the points we spoke about this afternoon 👍 |
alecananian
approved these changes
Feb 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This moves from a webview per-tab architecture to a singleton webview overlay simplifying state & navigation required for moving between the two runtimes. Back buttons, internal tab navigations, etc. should work correctly now.
There are a few remaining items related to this work, but I'd like to get it merged so we can try it against the test build. I logged issues in Linear for tracking the following remaining items:
dev:ios:localscript that simplifies running against the local dev server. Needs to be fixed, hardcoded right nowFixes LAND-1504