perf: speed up sidebar sorter #3317
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I was getting annoyed with how slow the sidebar can be, so I did a performance profile and root caused that this particular function was pretty heavy. Saw a marked improvement in performance for this function by just pre-computing the values for comparison before running the comparison and eliminating the use of .reverse(). Change should be most noticeable when navigating back to the main groups list from a group, or just loading the app initially. There's still some slowness with the group sidebar itself, which we should root cause at some point.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I was getting annoyed with how slow the sidebar can be, so I did a performance profile and root caused that this particular function was pretty heavy.
Saw a marked improvement in performance for this function by just pre-computing the values for comparison before running the comparison and eliminating the use of .reverse().
Note that this isn't a cure-all, I just decided to take a weed wacker to the tallest weed on a cursory look.
tested locally by running the dev server against my livenet planet.
No idea if there's a linear ticket for sidebar perf.
PR Checklist