Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chat input: fix rerendering issue on last message delivered #3327

Merged
merged 2 commits into from
Mar 12, 2024
Merged

chat input: fix rerendering issue on last message delivered #3327

merged 2 commits into from
Mar 12, 2024

Conversation

patosullivan
Copy link
Member

This fixes LAND-1678 by moving lastMessageId into a ref, preventing onUpArrow from changing and thus causing the message editor to re-render.

Tested locally on a livenet moon.

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@linear Linear
Copy link

linear bot commented Mar 12, 2024

LAND-1678 chat input: sending multiple messages in succession wipes chat input

arthyn
arthyn approved these changes Mar 12, 2024
View reviewed changes
Copy link
Member

@arthyn arthyn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@patosullivan patosullivan merged commit 93b1acd into develop Mar 12, 2024
1 check failed
@patosullivan patosullivan deleted the po/land-1678-fix-chat-input-rerendering-again branch March 12, 2024 18:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@arthyn arthyn arthyn approved these changes

@latter-bolden latter-bolden Awaiting requested review from latter-bolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@patosullivan @arthyn