e2e: fix e2e by fixing state transitions in %notify #3335
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fixes LAND-1682 by fixing an issue in the state types in %notify. At one point, the `notification` type changed and was subtly wrong. This went unnoticed because we used to drop old state anytime it didn't match the current state type. This began to fail when we introduced changes to the %notify agent that included state transitions and there were ships that had not yet had that old state dropped. This particularly effected the fake ships we use for e2e tests, because they boot with an old version of %groups. This would have also effected any ships that had not yet dropped their old state %3 and replaced it with the "new" state %3 with the bad notification type. We get around this issue by just accepting any noun for the `notifications` type for base-state-2 and base-state-3, and creating a new base-state-4 with the correct type. Ships on either version of state %3 or already on state %4 should transition without issue now.
Fang-
approved these changes
Mar 14, 2024
patosullivan
deleted the
po/land-1682-e2e-fix-commit-hash-diff-issue-by-fixing-notify-state
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes LAND-1682 by fixing an issue in the state types in %notify.
At one point, the
notificationtype changed and was subtly wrong. This went unnoticed because we used to drop old state anytime it didn't match the current state type.This began to fail when we introduced changes to the %notify agent that included state transitions and there were ships that had not yet had that old state dropped.
This particularly effected the fake ships we use for e2e tests, because they boot with an old version of %groups. This would have also effected any ships that had not yet dropped their old state %3 and replaced it with the "new" state %3 with the bad notification type.
We get around this issue by just accepting any noun for the
notificationstype for base-state-2 and base-state-3, and creating a new base-state-4 with the correct type. Ships on either version of state %3 or already on state %4 should transition without issue now.