groups: don't crash during "can read" on-peek #3349
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The scry endpoints for a group's channels' permission checks would crash if the channel did not exist in that group. In cases where the channel was deleted, other agents might still know about the channel, and so still try to ask the group about relevant permissions, but the scry handling would crash. Here we update the scry logic to not crash, and instead produce a "not allowed to read" flag in cases where the asked-about channel doesn't exist in the group. We suspect this will ameliorate at least some of the problems seen around role modifications and permission rechecks, as this crashing scry was causing group fact handling to crash, causing locally-originating kicks, causing resubscribes.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The scry endpoints for a group's channels' permission checks would crash if the channel did not exist in that group. In cases where the channel was deleted, other agents might still know about the channel, and so still try to ask the group about relevant permissions, but the scry handling would crash.
Here we update the scry logic to not crash, and instead produce a "not allowed to read" flag in cases where the asked-about channel doesn't exist in the group.
We suspect this will ameliorate at least some of the problems seen around role modifications and permission rechecks, as this crashing scry was causing group fact handling to crash, causing locally-originating kicks, causing resubscribes.Don't get your hopes up.