tests: support loading custom vase in +do-load #3361
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This way, state migrations may be tested, and agent state may be created ex-nihilo instead of needing to come about strictly through the normal lifecycle.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Was using this library for my own purposes recently and found that it offered no built-in affordance for modifying state or injecting state wholesale. Since
+on-loadgets called with avase, seems appropriate for+do-loadto accept that as an argument.This way, state migrations may be tested, and agent state may be created ex-nihilo instead of needing to come about strictly through the normal lifecycle.
We take a
(unit vase)so that it remains easy to fall back to+on-save's output.(Includes some tiny stylistic touch-ups to the library as well.)