Unify Prettier config #3372
Merged
Unify Prettier config #3372
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
dnbrwstr
changed the title
dnbrwstr
requested review from
patosullivan,
alecananian and
arthyn
and removed request for
patosullivan
|
Needs some work, drafting for now. |
|
Drafting again, I think we should probably wait and merge this and reformat the shared packages at the same time, but want to coordinate on when with @patosullivan and @alecananian. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR creates a root
.prettierrc.jsfor common formatting settings. I also added new.prettierrc.jsfiles for thesharedanduipackages, which were missing them before.One small future improvement would be to also hoist config for the import order plugin -- I didn't do that here because I started seeing import/module issues during formatting when I did.
This PR doesn't actually reformat code where the config has changed. Nothing should change in the
tlon-webandtlon-mobilepackages, but there will be a number of formatting changes in theuiandsharedpackages. We should coordinate on the right time to do that.