sidebar sort: fix issue with recency #3390
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
My recent change to useRecentSort() didn't account for the fact that some channels/dms don't have any unreads. This led to a bizarre looking recent sort order for groups. This fixes that by defaulting to Number.NEGATIVE_INFINITY if we can't find an unread (rather than only if we can't find recency). Fixes LAND-1747
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
My recent change to useRecentSort() didn't account for the fact that some channels/dms don't have any unreads.
This led to a bizarre looking recent sort order for groups.
This fixes that by defaulting to Number.NEGATIVE_INFINITY if we can't find an unread (rather than only if we can't find recency).
Tested locally on a live ship.
Fixes LAND-1747
PR Checklist