groups: fix issue where admins can't delete if they're not the host #3404
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Fang-
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
As discussed out of band, this indeed matches the group-wide permission scry endpoint we do implement:
tlon-apps/desk/app/groups.hoon
Line 1005 in 7230eb6
Good catch, thank you!
patosullivan
deleted the
po/land-1756-group-admins-cant-delete-if-not-host
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Apparently the
is-adminutil has been broken. It was scrying into the wrong place to check if a user is an admin. It only appeared to work because of an early return where we check if the ship is also the host of the channel.If an admin was not also the host of the channel, then they were not able to delete messages in that channel.