Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

channels: remove duplicate replies #3422

Merged
merged 2 commits into from
Apr 15, 2024
Merged

channels: remove duplicate replies #3422

merged 2 commits into from
Apr 15, 2024

Conversation

arthyn
Copy link
Member

@arthyn arthyn commented Apr 15, 2024

Fixes LAND-1754 and LAND-1764, heap detail wasn't even checking pending and we needed to do the same de-duping with replies as we did with posts.

PR Checklist

  • Includes changes to desk files
  • Describes how you tested the PR locally (test ship vs livenet)
  • If a new feature, includes automated tests
  • Comments added anywhere logic may be confusing without context

@linear Linear
Copy link

linear bot commented Apr 15, 2024

LAND-1754 pending messages: "duplicated" thread replies

LAND-1764 pending messages: can see pending state for posts sent by others

patosullivan
patosullivan approved these changes Apr 15, 2024
View reviewed changes
Copy link
Member

@patosullivan patosullivan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@arthyn arthyn merged commit bc13c08 into develop Apr 15, 2024
1 check passed
@arthyn arthyn deleted the hm/fix-duplicated-replies branch April 15, 2024 20:30
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@patosullivan patosullivan patosullivan approved these changes

@latter-bolden latter-bolden Awaiting requested review from latter-bolden

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
2 participants
@arthyn @patosullivan