Making _x translatable text work #57
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tlovett1
added a commit
that referenced
this pull request
Aug 27, 2014
Making _x translatable text work
jameswburke
pushed a commit
to alleyinteractive/safe-redirect-manager
that referenced
this pull request
Jul 24, 2019
…dar-Plugin Add the events calendar plugin
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Hi,
I've noticed that translatable text that uses _x does not seem to work correctly (for example, the "Create Redirect Rule" button).
What I did to fix this in my installation was:
Add the textdomain to the 3 _x translatable text (see pull request)
In the .po file the context (msgctxt) needs to be manually added if you're using POEdit as it doesn't seem to be able to extract it from source when the context is defined as $this->redirect_post_type (so I manually had to add msgctxt "redirect_rule").
Hope it is helpful