New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Support for X9.62 formatted public keys #118
Conversation
1111ff9
to
d1670c7
Compare
@trancee, @mdxs, @mg6maciej, @techguy613, @SimoneBronzini, @florensie, @nomeata: (I've tagged you as you have expressed interest in this feature in one of the above mentioned PRs or issues) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM (with or without the exception name change)
Adds support for encoding and decoding verifying keys in format specified in SEC 1 or in X9.62. Specifically the uncompressed point encoding and the compressed point encoding
make the decoding of malformed point raise the same exception irrespective of the formatting of the key/public point
reuse the new to_string and from_string to support saving and reading the public key in PEM and DER files with both compressed and uncompressed point encoding
the X9.62 standard defines also a hybrid public key representation, add support for it
53783c3
to
cb15e5f
Compare
This is re-working of the PR #54 (which in turn is a reworking of #34).
This implements support for the compressed, uncompressed and hybrid format specified in X9.62 and the SEC1 standards
http://www.secg.org/sec1-v2.pdf
fixes #1, #53
closes #54, #34
I'm not adding documentation as I plan to do that either in #117 or after #117 is merged