Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow limiting point formats, don't accept malformed PEM public files #251

Merged
merged 1 commit into from
Apr 26, 2021

Conversation

tomato42
Copy link
Member

Allow specifying what point formats are supported when loading public
keys. Limit the point formats when loading PEM and DER public files
to the formats actually allowed in them: uncompressed, compressed,
and hybrid. Previous code would allow raw encoding too.

fixes #214

@tomato42 tomato42 added the bug unintended behaviour in ecdsa code label Apr 24, 2021
@tomato42 tomato42 added this to the v0.17.0 milestone Apr 24, 2021
@tomato42 tomato42 self-assigned this Apr 24, 2021
Allow specifying what point formats are supported when loading public
keys. Limit the point formats when loading PEM and DER public files
to the formats actually allowed in them: uncompressed, compressed,
and hybrid. Previous code would allow raw encoding too.
Copy link

@Jakuje Jakuje left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@tomato42 tomato42 merged commit b4c4203 into tlsfuzzer:master Apr 26, 2021
@tomato42 tomato42 deleted the raw-encoding branch April 26, 2021 13:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug unintended behaviour in ecdsa code
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Limit acceptable point encoding formats (raw encoding in ASN.1 files)
2 participants