Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix PHA with KeyUpdate with HTTP #380

Merged
merged 1 commit into from
Dec 11, 2019
Merged

fix PHA with KeyUpdate with HTTP #380

merged 1 commit into from
Dec 11, 2019

Conversation

tomato42
Copy link
Member

@tomato42 tomato42 commented Dec 4, 2019 •
edited
Loading

with HTTP flows and PHA we need some special handling of KeyUpdate
so add it

This change is Reviewable

@tomato42 tomato42 added the bug unintented behaviour in tlslite-ng code label Dec 4, 2019
@tomato42 tomato42 added this to the v0.8.0 milestone Dec 4, 2019
@tomato42 tomato42 self-assigned this Dec 4, 2019
@tomato42 tomato42 added this to To do in TLS 1.3 support via automation Dec 4, 2019
@tomato42 tomato42 moved this from To do to In progress in TLS 1.3 support Dec 4, 2019
@tomato42 tomato42 requested a review from t184256 December 4, 2019 15:20
@tomato42
fix PHA with KeyUpdate with HTTP
ee4695c 
with HTTP flows and PHA we need some special handling of KeyUpdate
so add it
@tomato42
Copy link
Member Author

tomato42 commented Dec 4, 2019

@t184256 test case updated, now it fails when the tlsrecordlayer change is removed

@tomato42 tomato42 mentioned this pull request Dec 4, 2019
Merged
13 tasks
t184256
t184256 approved these changes Dec 11, 2019
View reviewed changes
Copy link
Collaborator

@t184256 t184256 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can't log into Reviewable for some reason.

Looks fine now, after I've learned that _handle_keyupdate_request only yields (0, 1) and since the test results now depend on the change.

@tomato42 tomato42 merged commit f119252 into master Dec 11, 2019
TLS 1.3 support automation moved this from In progress to Done Dec 11, 2019
@tomato42 tomato42 deleted the pha-determinism branch December 11, 2019 12:39
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@t184256 t184256 t184256 approved these changes

Assignees

@tomato42 tomato42

Labels
bug unintented behaviour in tlslite-ng code
Projects
TLS 1.3 support
  
Done
Milestone
v0.8.0
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@tomato42 @t184256