Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

awnet_local_data_<mac_address> as file name can't copy in Windows #26

Closed
heyitsyang opened this issue Jun 9, 2023 · 1 comment · Fixed by #30
Closed

awnet_local_data_<mac_address> as file name can't copy in Windows #26

heyitsyang opened this issue Jun 9, 2023 · 1 comment · Fixed by #30
Labels
bug Something isn't working

Comments

@heyitsyang
Copy link

Integration Version:
v1.1.1

Home Assistant Version:
2023.5.4

Describe the bug
A clear and concise description of what the bug is.

The integration creates a file in the .storage directory whose filename is incompatible with the Windows filesystem due to use of colons ( : ) in the filename. This prevents copying of this file using Windows as a mechanism for directly copying this file for backups and other purposes.

To Reproduce
Steps to reproduce the behavior:

  1. Go to '...'
  2. Click on '....'
  3. Scroll down to '....'
  4. See error

Expected behavior
A clear and concise description of what you expected to happen.

Expected behavior is the ability to use Samba and other methods to copy the file using Windows

Screenshots
If applicable, add screenshots to help explain your problem.

Additional context
Add any other context about the problem here.

Debug log output from the integration (see Home Assistant docs for how to enable debug logging for an integration; integration name: "custom_components.awnet_local")

Paste your logs here

Screenshot 2023-06-09 161504

@heyitsyang heyitsyang added the bug Something isn't working label Jun 9, 2023
@tlskinneriv
Copy link
Owner

This is a legitimate usage that I simply had not thought of. Will work the fix into the next release. Thanks!

tlskinneriv added a commit that referenced this issue Jun 17, 2023
Fixed:
- Storage key for data to valid Windows file path, migration on first run, resolves
  [#26](#26)
- Last Rain sensor now behaving correctly, was previously updating to "Unknown" when it had no data,
  resolves [#28](#28)
- Keys for lightning data storage are converted to strings by the storage provider, perform
  conversions when data is accessed, resolves
  [#29](#29)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

Successfully merging a pull request may close this issue.

2 participants