Add notary client crate #489
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sinui0
requested changes
May 27, 2024
|
@yuroitaki, after you guys finalize all the details, pls ping me for a review, thanks. |
sinui0
requested changes
Jun 12, 2024
yuroitaki
commented
Jun 12, 2024
sinui0
approved these changes
Jun 13, 2024
themighty1
approved these changes
Jun 13, 2024
There was a problem hiding this comment.
good work! I fixed the method name comments Create->Creates but I didn't fix all the instances of a missing final period that we put at the end of both doc comments and regular comments since there were too many of them.
i think Ideally we should add punctuation at least to the new code that we add (regardless if the surrounding code in unpunctuated).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addressed #443, where
Another PR will follow to migrate this notary client crate to the notary server folder (the migration touches many parts of the codebase (e.g. github action, devops deployment scripts, notary server dockerfile), hence a separate PR is better to reduce the review scope)