PUT rearchitecture: implement OpenSSL C PUT #319
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
michaelmera
force-pushed
the
michaelmera/openssl-c-harness
branch
3 times, most recently
from
a04a9b5
to
5ea47da
Compare
michaelmera
force-pushed
the
michaelmera/openssl-c-harness
branch
from
5ea47da
to
cd2fe23
Compare
The PutName was a bounded array type of 10 characters. Since we will need to identify PUTs with a fullname when using C PUTs, we relax this constraint and use String instead.
Since we are imposing clang as compiler for tlspuffin and its dependencies, we can link against libc++ regardless of platform considerations. This also fixes the build on intel-based macos.
michaelmera
force-pushed
the
michaelmera/openssl-c-harness
branch
from
cd2fe23
to
4ed9fe0
Compare
michaelmera
force-pushed
the
michaelmera/openssl-c-harness
branch
from
4ed9fe0
to
460a296
Compare
michaelmera
force-pushed
the
michaelmera/openssl-c-harness
branch
from
460a296
to
4e0f1a4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
NOTE: This PR is an attempt to restrict the scope of PR #282 by extracting the commits laying the groundwork for the architectural changes.
This PR introduces the C harness for the OpenSSL PUT.