Replace suppressSequenceNumber with transport-specific behavior #51
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think I have addressed this aspect already in PR #49 |
|
Correct. I thought Ben's suggestion to tie it to transport made more sense, but I'm not hard over on it. |
|
Fine for me too. |
bemasc
reviewed
Mar 7, 2022
bemasc
reviewed
Mar 7, 2022
draft-ietf-tls-ctls.md
Outdated
| the `suppressSequenceNumber` flag in the compression profile being used (see | ||
| {{template-based-specialization}}). When this flag is enabled, the S bit in the | ||
| configuration octet MUST be cleared. | ||
| field entirely. When a reliable transport (e.g., TCP) is in use, the |
There was a problem hiding this comment.
Suggested change
| field entirely. When a reliable transport (e.g., TCP) is in use, the | |
| field entirely. When a reliable, ordered transport (e.g., TCP) is in use, the |
Co-authored-by: Benjamin M. Schwartz <bemasc@google.com>
| {{template-based-specialization}}). When this flag is enabled, the S bit in the | ||
| configuration octet MUST be cleared. | ||
| field entirely. When a reliable, ordered transport (e.g., TCP) is in use, the | ||
| S bit in the configuration octet MUST be cleared and the sequence number |
There was a problem hiding this comment.
S = stream transport ?
|
S = "sequence number"
…On Tue, Mar 8, 2022 at 3:53 AM Martin Thomson ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In draft-ietf-tls-ctls.md
<#51 (comment)>
:
> @@ -410,11 +410,10 @@ transports (e.g., TCP), the length field MUST be present. For use over other
transports length information may be inferred from the underlying layer.
Normal DTLS does not provide a mechanism for suppressing the sequence number
-field entirely. In cases where a sequence number is not required (e.g., when a
-reliable transport is in use), a cTLS implementation may suppress it by setting
-the `suppressSequenceNumber` flag in the compression profile being used (see
-{{template-based-specialization}}). When this flag is enabled, the S bit in the
-configuration octet MUST be cleared.
+field entirely. When a reliable, ordered transport (e.g., TCP) is in use, the
+S bit in the configuration octet MUST be cleared and the sequence number
S = stream transport ?
—
Reply to this email directly, view it on GitHub
<#51 (review)>,
or unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAIPLIMKLBNYM7GCFTUTG73U645TPANCNFSM5QD5MIYQ>
.
Triage notifications on the go with GitHub Mobile for iOS
<https://apps.apple.com/app/apple-store/id1477376905?ct=notification-email&mt=8&pt=524675>
or Android
<https://play.google.com/store/apps/details?id=com.github.android&referrer=utm_campaign%3Dnotification-email%26utm_medium%3Demail%26utm_source%3Dgithub>.
You are receiving this because you modified the open/close state.Message
ID: ***@***.***>
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm slightly concerned about the fact that we have two different wire behaviors with the same transcript, but because the integrity tag includes the header, I think it's OK.
@martinthomson would welcome your thoughts.