Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Address minor spec issues #308

Merged
merged 1 commit into from Sep 24, 2020
Merged

Address minor spec issues #308

merged 1 commit into from Sep 24, 2020

Conversation

cjpatton
Copy link
Contributor

@cjpatton cjpatton commented Sep 23, 2020 •
edited

Based on my experience implementing this extension (see cloudflare/go#30), I'd like to recommend a few changes to the spec. Most notably:

  1. Change the constants so that they're consistent.
  2. Specify the client/server behavior in a few failure scenarios.

There are also some editorial changes:

  1. Rename "HpkeCipherSuite" to "ECHCipherSuite". (An HPKE cipher suite consists of a KEM, KDF, and AEAD, but here a cipher suite is a KDF and an AEAD.)
  2. Rename "OuterExtensions.hash" to "OuterExtensions.inner_digest".
  3. Rename "ClientECH.encrypted_ch" to "ClientECH.payload".

Partially addresses #285.

@cjpatton cjpatton mentioned this pull request Sep 23, 2020
Closed
chris-wood
chris-wood requested changes Sep 23, 2020
View reviewed changes
Copy link
Collaborator

@chris-wood chris-wood left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Couple of very small nits!

draft-ietf-tls-esni.md Outdated Show resolved Hide resolved
draft-ietf-tls-esni.md Outdated Show resolved Hide resolved
draft-ietf-tls-esni.md Outdated Show resolved Hide resolved
draft-ietf-tls-esni.md Outdated
@@ -767,7 +776,9 @@ messages, but just blindly forwards them.

If the server sends a NewSessionTicket message, the corresponding ECH PSK MUST
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Perhaps this can say that servers MUST NOT use this PSK if ECH is rejected?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That's ensured by the rule change above, correct? If so, then the server won't send a NewSessionTicket message.

Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yep!

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I dropped the TODO and left the text as-is for now.

@chris-wood chris-wood merged commit 4b6f0d7 into tlswg:master Sep 24, 2020
@cjpatton cjpatton deleted the nits branch April 16, 2021 19:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@chris-wood chris-wood chris-wood approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cjpatton @chris-wood