Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Invalid records and impact on timers #224

Closed
hannestschofenig opened this issue Apr 5, 2021 · 4 comments
Closed

Invalid records and impact on timers #224

hannestschofenig opened this issue Apr 5, 2021 · 4 comments

Comments

@hannestschofenig
Copy link
Collaborator

Zaheduzzaman Sarker wrote

  • Section 4.5.2: I assume the silent discard of invalid records will not impact the timers, is that a valid assumption? if yes, then it would be good if this is clarified in the text.

-> need to add text

@ekr
Copy link
Collaborator

ekr commented Apr 6, 2021

I don't actually understand the ask here. Why would it matter?

@hannestschofenig
Copy link
Collaborator Author

I believe he wants us to note that when an invalid record is received and silently discarded then it does not impact timers in any way. It would be surprising if it did but do we want to add a sentence about that?

@kaduk
Copy link
Contributor

kaduk commented Apr 12, 2021

Since we have a dedicated section for "handling invalid records" that does allow for things other than silent discard, it makes sense to mention the lack of effect on timers. "[...] however, an error MAY be logged for diagnostic purposes. In no case does an invalid record affect pending retransmission timers."?

@ekr
Copy link
Collaborator

ekr commented Apr 13, 2021

I'm not sure I agree, but I added something.

chris-wood added a commit that referenced this issue Apr 13, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants