Renaming HandshakeType names in IANA request #265
Conversation
|
As far as referring to the snake case in the main body, I went and looked at RFC 8446 and it does not refer to the snake case. I tend to think that if we make the change in 5.2 and A.2, that should be enough breadcrumbs for people to figure it out. I put them in the same order as they are in the registry and moved up new_session_ticket. Triple check this change please. |
| case encrypted_extensions: EncryptedExtensions; | ||
| case certificate_request: CertificateRequest; | ||
| case request_connection_id: RequestedConnectionId; |
There was a problem hiding this comment.
Shouldn't this be just "RequestConnectionId", not "Requested"?
There was a problem hiding this comment.
Yes fixing this too.
| @@ -1130,12 +1132,14 @@ fragmentation, DTLS modifies the TLS 1.3 handshake header: | |||
| case client_hello: ClientHello; | |||
| case server_hello: ServerHello; | |||
| case end_of_early_data: EndOfEarlyData; | |||
| case new_session_ticket: NewSessionTicket; | |||
There was a problem hiding this comment.
I see NST (4) as before EOED (5) in the registry.
There was a problem hiding this comment.
Were we planning to order these by codepoint value in the final RFC?
There was a problem hiding this comment.
Yes ... will submit a new PR now to reorder
Resolves #264.