Curve25519->X25519 (and same for 448) plus add zero check #16
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
| <t> All-zeroes output from X25519 or X448 MUST NOT be used for premaster secret (as required by definition | ||
| of X25519 and X448). If the premaster secret would be all zeroes, the handshake MUST be aborted (most | ||
| probably by sending a fatal alert).</t> | ||
| <t> Let's define legitimate values of x as the values that can be obtained as x = X25519(G, d') for some |
Also fix apparent d vs d' mixup.
|
Renamed the curves to be consistent with what got merged into TLS 1.3 spec |
yoavnir
added a commit
that referenced
this pull request
Nov 14, 2015
Curve25519->X25519 (and same for 448) plus add zero check
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replace uses of Curve25519 with X25519 (and similarly with 448-bit one).
Also add zero checks as required by CFRG-CURVES. Because of problems with TLS 1.2 key exchange, omitting these checks leads to security issues.