Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Be more explicit about PSK requirements #1061

Merged
merged 2 commits into from Nov 13, 2017
Merged

Be more explicit about PSK requirements #1061

merged 2 commits into from Nov 13, 2017

Conversation

kaduk
Copy link
Contributor

@kaduk kaduk commented Jul 21, 2017

Both for 0-RTT and 1-RTT.

Give NST- and externally-provisioned PSKs more uniform treatment.

Closes: #1040
Closes: #1043

Both for 0-RTT and 1-RTT.

Give NST- and externally-provisioned PSKs more uniform treatment.

Closes: tlswg#1040
Closes: tlswg#1043
- The selected ALPN {{RFC7301}} protocol, if any.
- The selected SNI (Section 3 of {{RFC6066}}) value, if any.
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

list construction: remove the period

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I would move the text on external vs. ticket after the list so that you can use a colon. e.g.,

In addition, it MUST verify that
the following values are consistent with those associated with the selected
PSK:

- ...

These requirements are a superset of those needed to perform a 1-RTT
handshake using the PSK in question.  For externally established PSKs,
the associated values are those provisioned along with the key.  For
PSKs established via a NewSessionTicket message, the associated
values are those negotiated in the connection during which the ticket
was established.

match the values negotiated in the connection during which the ticket
was established:


Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

extra line

@kaduk
Copy link
Contributor Author

kaduk commented Aug 18, 2017

@ekr ping? It would be good to get some resolution in this space, as it's somewhat relevant to openssl/openssl#3926

@kaduk
Copy link
Contributor Author

kaduk commented Aug 18, 2017

I guess we could perhaps recommend that external PSKs not be provisioned with a SNI value, since the PSK value itself ought to serve as enough of a lookup key for what the intended communication semantics are.

@kaduk
Copy link
Contributor Author

kaduk commented Oct 9, 2017

@ekr is there a path forward for this (e.g., does it need to go to the list)?

@ekr
Copy link
Contributor

ekr commented Oct 27, 2017

@kaduk: I think this is generally good except for the SNI stuff which conflicts with PR #1080, which we also need to resolve one way or another. What say we land this without those pieces and then when we resolve #1080, we will know what to do

@kaduk
Copy link
Contributor Author

kaduk commented Oct 27, 2017

What say we land this without those pieces and then when we resolve #1080, we will know what to do

SGTM. Do you need me to adjust the patch?

@ekr
Copy link
Contributor

ekr commented Oct 27, 2017

Nah, I'll do it.

@ekr
Copy link
Contributor

ekr commented Oct 30, 2017

These actually just seem to make the SNI requirements clearer but no sharper, so merging.

@ekr ekr merged commit 215a303 into tlswg:master Nov 13, 2017
vasilvv added a commit to vasilvv/tls13-spec that referenced this pull request Nov 16, 2017
In order for cross-SNI resumption to work, SNI has to be a
per-connection property.  Reflect this in text.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants