Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a future extension to allow external PSKs and certificate-based… #1117

Merged
merged 3 commits into from
Dec 27, 2017

Conversation

russhousley
Copy link
Contributor

… authentication

Copy link
Contributor

@kaduk kaduk left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This feels like a strange wording to me (and I also personally don't feel that explicit text to this effect is needed, though neither do I object to such text).
(I would be more likely to use a phrasing that involves appending to the end of the (old) sentence something like ", unless explicitly enabled by some future protocol extension.")

@iluxonchik
Copy link
Contributor

iluxonchik commented Dec 10, 2017

I'm inclined to agree with @kaduk. A TLS extension can change anything it wants about the protocol, which means that in the limit, the text you suggested can be added next to every prohibition present in the draft, and while it does make sense to put it some places, this doesn't seem to be such a critical part that needs this mentioned, it just bulks up the spec.

If this edit is accepted, however, it might be a good idea to be consistent with the already existing wording and use

unless negotiated by some extension

instead, which is also less wordy and cognitively complex than the current one, while conveying the same information.

@davidben
Copy link
Contributor

Agreed with others. I won't be unhappy if the text is there, but I think it's redundant and makes an already rather long specification ever so slightly longer. Any extension is a minor (or major, in this document!) protocol revision and is thus allowed to define whatever semantics or protocol tweaks it needs to.

@ekr ekr merged commit 4385cb2 into tlswg:master Dec 27, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants