Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

md fixes #1329

Merged
merged 3 commits into from
Nov 5, 2023
Merged

md fixes #1329

merged 3 commits into from
Nov 5, 2023

Conversation

seanturner
Copy link
Contributor

Closes #1327 and addresses some I-D nits.

@martinthomson PTAL (obviously needs to be squshed).

Closes #1327 as well as some other nits I noted in the md along with ID-nits.  All ref to extensions that are not listed in the mandatory to implement extension I made informational.
@@ -1749,7 +1753,7 @@ appears, it MUST abort the handshake with an "illegal_parameter" alert.
| max_fragment_length [RFC6066] | CH, EE |
| status_request [RFC6066] | CH, CR, CT |
| supported_groups [RFC7919] | CH, EE |
| signature_algorithms (RFC8446) | CH, CR |
| signature_algorithms [RFC8446] | CH, CR |
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

For citations, I generally advise people to use {{RFC8446}} rather than [RFC8446]. kramdown-rfc will complain if you have {{NON-EXISTENT}}, but just put [NON-EXISTENT] straight into the document without a link, so the former is safer.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I may fix this later, but for now let's merge.

@ekr ekr merged commit f436206 into main Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

kramdown warnings
3 participants