Incorporate the accepted parts of PR #1357. Closes #1357. #1363
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martinthomson
approved these changes
Jul 31, 2024
draft-ietf-tls-rfc8446bis.md
Outdated
| but MAY do so if the client's advertisement permits it, | ||
| and MUST NOT do so otherwise. | ||
| This fallback chain MUST NOT use the deprecated SHA-1 hash, | ||
| except if advertised by the client, in which case it MAY. |
There was a problem hiding this comment.
This phrasing is weird. You could just say:
This fallback chain MUST NOT use the deprecated SHA-1 hash,
unless the client specifically advertises that it is willing to accept SHA-1.
The "MAY" bit is implied.
| @@ -2932,7 +2933,7 @@ for each scenario: | |||
| |------|-------------------|----------| | |||
| | Server | ClientHello ... later of EncryptedExtensions/CertificateRequest | server_handshake_traffic_secret | | |||
| | Client | ClientHello ... later of server Finished/EndOfEarlyData | client_handshake_traffic_secret | | |||
| | Post-Handshake | ClientHello ... client Finished + CertificateRequest | client_application_traffic_secret_N | | |||
| | Post-Handshake | ClientHello ... client Finished + CertificateRequest | [sender]_application_traffic_secret_N | | |||
There was a problem hiding this comment.
Suggested change
| | Post-Handshake | ClientHello ... client Finished + CertificateRequest | [sender]_application_traffic_secret_N | | |
| | Post-Handshake | ClientHello ... client Finished + CertificateRequest | \[sender]_application_traffic_secret_N | |
I'm not 100% on this, but I think that you need this.
There was a problem hiding this comment.
It seems to compile OK without this.
Co-authored-by: Martin Thomson <mt@lowentropy.net>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.