First cut at 1RTT handshake. Lots of OPEN ISSUEs and TODOs #52
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
I don't think the CertificateRequest needs to be limited to authenticated servers, or to certain ciphersuites. i note that RFC 5246 (TLS 1.2) does seem to suggest these same limitations, but it's not clear to me why they exist. If we're going for a simpler state machine for TLS 1.3, i see no reason to keep these limitations.
there is no "first handshake" any more, and the ChangeCipherSpec message is being sent much earlier here. The constraints replaced here don't make sense in the new model.
Since each SignatureAndHashAlgorithm is 2 octets, and at least one must be supported, the range is 2 - 2^16-2. Note that cipher_suites is already declared in the same way: CipherSuite cipher_suites<2..2^16-2>
ekr
added a commit
that referenced
this pull request
Jul 6, 2014
First cut at 1RTT handshake. Lots of OPEN ISSUEs and TODOs
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.