Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Issue644 remove hrr reconstruction #678

Merged
merged 3 commits into from
Oct 16, 2016

Conversation

ekr
Copy link
Contributor

@ekr ekr commented Oct 11, 2016

No description provided.

…lswg#644.

This makes CH-HRR-CH reconstruction impossible, which is a good thing
overall.
@ekr ekr modified the milestone: -17 Oct 11, 2016
an "unexpected message" if the HelloRetryRequest would not result in
any change in the ClientHello or in response to any second
HelloRetryRequest which was sent in the same connection (i.e., where
the ClientHello was itself in response to a HelloRetryRequest).
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

So the thing to note here is that HRR can't include extensions that you don't agree should be there. So, if extensions are present, then they have to be ones that change the ClientHello (we shouldn't define any that don't). That means the only way for HRR to be wrong is:

  • no extensions (decode_error)
  • unknown extension (unsupported_extension)
  • extension doesn't cause a change, for instance key_share uses an unknown group, or one that already had a share

In the last case, I chose to make this an illegal_parameter alert.

And yes, if you receive a second HRR, then unexpected_message is correct (note that you missed the underscore there).

I chose to send illegal_parameter

@davegarrett
Copy link
Contributor

On Tuesday, October 11, 2016 08:14:32 pm Martin Thomson wrote:

  • no extensions (decode_error)

or missing_extension

@martinthomson
Copy link
Contributor

I think that missing_extension would be OK, but we would hit the lower-level decode_error first, since HRR is defined with:

       Extension extensions<2..2^16-1>;

@ekr ekr modified the milestones: -17, 10/14 Oct 12, 2016
@ekr ekr merged commit 49e6e44 into tlswg:master Oct 16, 2016
davidben added a commit to davidben/tls13-spec that referenced this pull request Dec 29, 2016
This is a redo of PR tlswg#643 now that PR tlswg#678 has removed the appending
rule and resolved issue tlswg#644.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants