Shorter HKDF labels. Fixes #964. #977
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Per mailing list discussion, this allows us to have every HKDF-Expand just have one hash block of info.
|
Shouldn't "TLS 1.3, " be shortened to "tls13 "? Without that, several
of the labels would seem to blow blocks.
Also, "derived secret" seems unchanged, and is too long to fit into
a block, even with "tls13 " prefix.
|
|
Oops. Good catch. Script fail. |
|
@ilaril: fixed? |
davegarrett
reviewed
Apr 26, 2017
draft-ietf-tls-tls13.md
Outdated
| @@ -4376,7 +4376,7 @@ defined below: | |||
|
|
|||
| struct { | |||
| uint16 length = Length; | |||
| opaque label<10..255> = "TLS 1.3, " + Label; | |||
| opaque label<10..255> = "tls13 " + Label; | |||
There was a problem hiding this comment.
Maybe also change the max to 18? At minimum, sticking a short note somewhere on the reason for the label lengths would probably be worth doing. This affects interop, so this also needs a changelog entry.
|
Yeah, I'll add a note. I still have an issue for the ChangeLog so I will
add this as well
…On Tue, Apr 25, 2017 at 9:49 PM, Dave Garrett ***@***.***> wrote:
***@***.**** commented on this pull request.
------------------------------
In draft-ietf-tls-tls13.md
<#977 (comment)>:
> @@ -4376,7 +4376,7 @@ defined below:
struct {
uint16 length = Length;
- opaque label<10..255> = "TLS 1.3, " + Label;
+ opaque label<10..255> = "tls13 " + Label;
Maybe also change the max to 18? At minimum, sticking a short note
somewhere on the reason for the label lengths would probably be worth
doing. This affects interop, so this also needs a changelog entry.
—
You are receiving this because you authored the thread.
Reply to this email directly, view it on GitHub
<#977 (review)>,
or mute the thread
<https://github.com/notifications/unsubscribe-auth/ABD1oS65WLeGIsBOCbSMT_c_f0CyUZItks5rzszqgaJpZM4NIGWg>
.
|
|
Also, minimum label size looks to be still 10, presumably should be 7
with 6-byte prefix (as it 10 with 9-byte prefix).
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Per mailing list discussion, this allows us to have every HKDF-Expand just
have one hash block of info.
@ilaril would love your feedback.