Simplify implementation of config validator

tlux · May 10, 2019 · 8ba50b2 · 8ba50b2
1 parent 0ef9acb
commit 8ba50b2
Showing 1 changed file with 10 additions and 13 deletions.
diff --git a/lib/sftp_client/operations/connect.ex b/lib/sftp_client/operations/connect.ex
@@ -100,22 +100,19 @@ defmodule SFTPClient.Operations.Connect do
   defp validate_config(config) do
     config
     |> Map.from_struct()
-    |> Enum.find_value(:ok, fn
-      {_key, nil} ->
-        nil
-
-      {key, value} ->
-        case validate_config_value(key, value) do
-          :ok ->
-            nil
-
-          {:error, reason} ->
-            {:error,
-             %InvalidOptionError{key: key, value: value, reason: reason}}
-        end
+    |> Enum.find_value(:ok, fn {key, value} ->
+      case validate_config_value(key, value) do
+        :ok ->
+          nil
+
+        {:error, reason} ->
+          {:error, %InvalidOptionError{key: key, value: value, reason: reason}}
+      end
     end)
   end
 
+  defp validate_config_value(_key, nil), do: :ok
+
   defp validate_config_value(:private_key_path, path) do
     if File.exists?(Path.expand(path)) do
       :ok