Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Handle missing + character covariates #200

Merged
merged 8 commits into from
Mar 31, 2019
Merged

Handle missing + character covariates #200

merged 8 commits into from
Mar 31, 2019

Conversation

jeremyrcoyle
Copy link
Collaborator

  • Adds warnings and handling functionality for missingness in covariates and outcomes (imputes covariates, adds indicators, and optionally drops rows with missing outcomes)
  • Adds warnings and handling functionality for character covariates (converts to factors)

@jeremyrcoyle
Copy link
Collaborator Author

@rachaelvphillips let me know if this works for wash-b. Sorry I didn't get this to you sooner!

nhejazi
nhejazi approved these changes Mar 29, 2019
View reviewed changes
Copy link
Member

@nhejazi nhejazi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM -- thanks for the work on this. Sounds like this resolves #121.

@jeremyrcoyle jeremyrcoyle merged commit 5ea34d9 into master Mar 31, 2019
@jeremyrcoyle jeremyrcoyle mentioned this pull request Mar 31, 2019
Closed
@jeremyrcoyle jeremyrcoyle deleted the handle-missing branch June 20, 2019 19:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nhejazi nhejazi nhejazi approved these changes

@rachaelvp rachaelvp Awaiting requested review from rachaelvp

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jeremyrcoyle @nhejazi