New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add fat optional image flavor #10
Conversation
This is related to #7. Could you please elaborate your use case? Best would be with examples. |
@@ -0,0 +1 @@ | |||
.idea |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please add system specifics to your personal global gitignore.
See https://help.github.com/articles/ignoring-files/#create-a-global-gitignore
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oops 👍🏻
|
||
RUN apk add --no-cache \ | ||
py-pip && \ | ||
if [[ "${IMAGE_TYPE}" == "fat" ]]; then \ |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This looks a bit obscure for someone looking only for the slim version.
It would be great if we have a normal Dockerfile and a DaockerfileFat file, which is using the slim image as base image
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Could be, but in the case of inheritance we will increase the amount of layers. Also, not sure how this will work with build matrix then.
My current use case is with gitlab (yes, similar issue to #7), and I agree that it is a little bit user-specific. |
Add openjdk8 to the image
Closing this, following my comment above and the same rationale as #3 |
Let me know if this is something you would like to add.