Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add fat optional image flavor #10

Closed
wants to merge 9 commits into from
Closed

Conversation

AutomationD
Copy link

@AutomationD AutomationD commented Aug 7, 2018

Let me know if this is something you would like to add.

@tmaier
Copy link
Owner

tmaier commented Aug 17, 2018

This is related to #7.
However, I am still not convinced that this is needed.
If I would need any of this, I would run a dedicated image when necessary.
Just see my docker and github profiles. You will see lots of public images, dedicated for CI/CD.
I do have similar private images for my personal, non-public tooling

Could you please elaborate your use case? Best would be with examples.
It would be also great if other people would give their pros and cons for this.

@@ -0,0 +1 @@
.idea
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please add system specifics to your personal global gitignore.
See https://help.github.com/articles/ignoring-files/#create-a-global-gitignore

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oops 👍🏻


RUN apk add --no-cache \
py-pip && \
if [[ "${IMAGE_TYPE}" == "fat" ]]; then \
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks a bit obscure for someone looking only for the slim version.
It would be great if we have a normal Dockerfile and a DaockerfileFat file, which is using the slim image as base image

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Could be, but in the case of inheritance we will increase the amount of layers. Also, not sure how this will work with build matrix then.

@AutomationD
Copy link
Author

My current use case is with gitlab (yes, similar issue to #7), and I agree that it is a little bit user-specific.
Although, to me, it seems that there could be a version of docker-compose-ci, which includes most of common CI utils.
For now Im building it by myself, It would just be nice to keep a ci (fat) version up-to-date alongside with build matrix updates.

@tmaier
Copy link
Owner

tmaier commented Apr 12, 2019

Closing this, following my comment above and the same rationale as #3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants