Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

From PIL import #140

Merged
merged 2 commits into from
Nov 6, 2016
Merged

From PIL import #140

merged 2 commits into from
Nov 6, 2016

Conversation

zuphilip
Copy link
Collaborator

@zuphilip zuphilip commented Nov 4, 2016

This should solve #96

@zuphilip
Copy link
Collaborator Author

zuphilip commented Nov 5, 2016

I also deleted a duplicate import statement which was hidden in the main content below.

kba
kba requested changes Nov 5, 2016
View reviewed changes
Copy link
Collaborator

@kba kba left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can you do the "import not at the beginning" fixes in a separate branch? There are more such statements scattered in e.g. common.py, lstm.py etc. and it's more a code style issue that we could correct in one clear sweep.

@zuphilip
Copy link
Collaborator Author

zuphilip commented Nov 5, 2016

Okay, I delete the last two commits form here and will create a new PR with them.

@zuphilip zuphilip mentioned this pull request Nov 5, 2016
Merged
@kba kba merged commit 97607ae into master Nov 6, 2016
@kba kba deleted the from-pil-import branch November 6, 2016 01:15
@zuphilip zuphilip mentioned this pull request Nov 20, 2016
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kba kba kba approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zuphilip @kba