Updates to satisfy PR review

tmbo · Aug 14, 2022 · ccf5382 · ccf5382
1 parent 6c9da13
commit ccf5382
Show file tree

Hide file tree

Showing 2 changed files with 6 additions and 3 deletions.
diff --git a/questionary/prompt.py b/questionary/prompt.py
@@ -145,15 +145,15 @@ def unsafe_prompt(
         if "type" not in question_config:
             raise PromptParameterException("type")
         # every type except 'print' needs a name
-        if "name" not in question_config and question_config["type"] != "print": # noqa
+        if "name" not in question_config and question_config["type"] != "print":
             raise PromptParameterException("name")
 
         _kwargs = kwargs.copy()
         _kwargs.update(question_config)
 
         _type = _kwargs.pop("type")
         _filter = _kwargs.pop("filter", None)
-        name = _kwargs.pop("name", None) if _type == "print" else _kwargs.pop("name") # noqa
+        name = _kwargs.pop("name", None) if _type == "print" else _kwargs.pop("name")
         when = _kwargs.pop("when", None)
 
         if true_color:

diff --git a/tests/test_prompt.py b/tests/test_prompt.py
@@ -2,6 +2,7 @@
 
 from questionary.prompt import PromptParameterException
 from questionary.prompt import prompt
+from tests.utils import patched_prompt
 
 
 def test_missing_message():
@@ -65,4 +66,6 @@ def test_missing_print_message():
 def test_print_no_name():
     """'print' type doesn't require a name so it
     should not throw PromptParameterException"""
-    assert prompt([{"type": "print", "message": "Hello World"}]) == {}
+    questions = [{"type": "print", "message": "Hello World"}]
+    result = patched_prompt(questions, "")
+    assert result == {}