Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

j/k to navigate up/down in select? #2

Closed
aldanor opened this issue Jan 8, 2019 · 3 comments
Closed

j/k to navigate up/down in select? #2

aldanor opened this issue Jan 8, 2019 · 3 comments
Labels
Enhancement New feature or request

Comments

@aldanor
Copy link

aldanor commented Jan 8, 2019

This being a command line tool, after all, I was surprised j/k wasn't the primary mean of navigation up and down already - would appreciate if it was supported :)

@tmbo
Copy link
Owner

tmbo commented Jan 8, 2019

Great suggestion, I am on mobile right now, but this is rather easy to add, you'd just need to add the keybindings in
https://github.com/tmbo/questionary/blob/master/questionary/prompts/checkbox.py#L134
and
https://github.com/tmbo/questionary/blob/master/questionary/prompts/select.py#L123

I'd be happy to merge a PR 😉

@tmbo tmbo added the Enhancement New feature or request label Jan 8, 2019
@tmbo tmbo closed this as completed in ee69b65 Jan 11, 2019
@tmbo
Copy link
Owner

tmbo commented Jan 11, 2019

I've implemented this on master 🙂

@aldanor
Copy link
Author

aldanor commented Jan 11, 2019

That's awesome, thank you! (apologies for falling out for a bit, busy times)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Enhancement New feature or request
Projects
None yet
Development

No branches or pull requests

2 participants