fix(types): declare support for single questions #191
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Without this patch, when calling `prompt` or `unsafe_prompt` with a `dict` on `questions`, mypy fails with:
Argument 1 to "unsafe_prompt" has incompatible type "Dict[str, Any]"; expected "Iterable[Mapping[str, Any]]"
yajo
force-pushed
the
fix-single-prompt-types
branch
from
83391fa
to
d0b4fa6
Compare
yajo
added a commit
to copier-org/copier
that referenced
this pull request
Dec 19, 2021
Includes workaround for tmbo/questionary#191.
yajo
added a commit
to copier-org/copier
that referenced
this pull request
Dec 19, 2021
Includes workarounds for tmbo/questionary#191 and pydantic/pydantic#3175.
tmbo
approved these changes
Dec 19, 2021
yajo
added a commit
to copier-org/copier
that referenced
this pull request
Jan 3, 2022
Includes workarounds for tmbo/questionary#191 and pydantic/pydantic#3175.
yajo
added a commit
to copier-org/copier
that referenced
this pull request
Jan 3, 2022
Includes workarounds for tmbo/questionary#191 and pydantic/pydantic#3175.
yajo
added a commit
to copier-org/copier
that referenced
this pull request
Jan 4, 2022
Includes workarounds for tmbo/questionary#191 and pydantic/pydantic#3175.
yajo
added a commit
to copier-org/copier
that referenced
this pull request
Jan 4, 2022
Includes workarounds for tmbo/questionary#191 and pydantic/pydantic#3175.
yajo
added a commit
to copier-org/copier
that referenced
this pull request
Jan 11, 2022
Includes workarounds for tmbo/questionary#191 and pydantic/pydantic#3175.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What is the problem that this PR addresses?
Without this patch, when calling
promptorunsafe_promptwith adictonquestions, mypy fails with:How did you solve it?
As dict is a valid supported input, I added it to the typing information, joined within an
Uniontype.Checklist