Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix bug in Makefile introduced in #270 #291

Merged
merged 1 commit into from
Jun 30, 2023
Merged

Fix bug in Makefile introduced in #270 #291

merged 1 commit into from
Jun 30, 2023

Conversation

kiancross
Copy link
Collaborator

What is the problem that this PR addresses?

A change made in #270 introduced a bug to the Makefile.

How did you solve it?

I changed the Makefile to use the new --with=docs argument.

Checklist

  • I have read the Contributor's Guide.
  • I will check that all automated PR checks pass before the PR gets reviewed.

@kiancross kiancross requested a review from tmbo June 30, 2023 01:25
tmbo
tmbo approved these changes Jun 30, 2023
View reviewed changes
Copy link
Owner

@tmbo tmbo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Lgtm

@kiancross kiancross merged commit 075a291 into tmbo:master Jun 30, 2023
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tmbo tmbo tmbo approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@kiancross @tmbo