Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

ci: Add linting, building, and testing to ci #42

Merged
merged 3 commits into from
Apr 21, 2023

Conversation

Fraser-Isbester
Copy link
Contributor

@Fraser-Isbester Fraser-Isbester commented Apr 21, 2023

summary: add's CI linting, building, and testing. Corrects existing lint failures.

closes #6
supersedes #13

PR Checklist

  • Read the Contributing documentation.
  • Read the Code of conduct documentation.
  • Name your Pull Request title clearly, concisely, and prefixed with the name of primarily affected package you changed according to Good commit messages (such as memory: add interfaces for X, Y or util: add whizzbang helpers).
  • Check that there isn't already a PR that solves the problem the same way to avoid creating a duplicate.
  • Provide a description in this PR that addresses what the PR is solving, or reference the issue that it solves (e.g. fixes #123).
  • Describes source of new concepts.
  • References existing implementations as appropriate.
  • Contains test coverage for new functions.
  • Passes all golangci-lint checks.

@tmc
Copy link
Owner

tmc commented Apr 21, 2023

LGTM

@tmc tmc merged commit 11bc927 into tmc:main Apr 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add golangci-lint github action
2 participants