feat!: Add a new error type for handshake timeouts #37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tmccombs
force-pushed
the
timeout-errors
branch
from
62e233e
to
11be9ad
Compare
And make the errors enun non_exhaustive BREAKING CHANGE: Adds a new variant to the Error Enum BREAKING CHANGE: The Error enum is now non_exhaustive BREAKING CHANGE: Now returns an error if a handshake times out Fixes: #36
tmccombs
force-pushed
the
timeout-errors
branch
from
11be9ad
to
6bd78b6
Compare
…it in errors. BREAKING CHANGE: The enum variant `Error::ListenerError` is now struct-like instead of tuple-like, and is `non_exhaustive` like the enum itself. BREAKING CHANGE: `Error` now has three type parameters, not two. BREAKING CHANGE: `TlsListener::accept` and `<TlsListener as Stream>::next` yields a tuple of (connection, remote address), not just the connection. BREAKING CHANGE: `AsyncAccept` now has an associated type `Address`, which `poll_accept` must now return along with the accepted connection.
tmccombs
force-pushed
the
timeout-errors
branch
from
0c10e7c
to
3a3c78a
Compare
This builds on the previous commit. In addition to some minor stylictic and naming changes (such as calling the address peer_addr instead of remote_addr to be more consistent with tokio and stdlib), the main change here is replacing the FutureWithExtraData with a more purpose-built Waiting struct encodes the state of a connection that is waitinf for a handshake to complete. BREAKING CHANGE: AsyncAccept::Error must implement std::error::Error BREAKING CHANGE: TlsAcceptError is now a struct form variant. Fixes: #36
tmccombs
force-pushed
the
timeout-errors
branch
from
3a3c78a
to
23ca7ff
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
And make the errors enun non_exhaustive
BREAKING CHANGE: Adds a new variant to the Error Enum
BREAKING CHANGE: The Error enum is now non_exhaustive
BREAKING CHANGE: Now returns an error if a handshake times out
Fixes: #36