Escape backslashes used in -D flags on Windows. #50
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Setup.hs
as it is onmaster
yields thiscuda.buildinfo.generated
on my Windows 10 machine (GHC 8.2.1, Stack 1.5.1):With this,
stack build --stack-yaml=stack-8.2.yaml
yields this:This seems related to @yuhangwang's issue #48. Escaping the backslashes in the -D flags let's the build proceed, like so:
Strangely this only must be done with the -D flags; there's something strange among Windows, MinGW, and/or c2hs going on. This patch has
Setup.hs
escape the backslashes when on Windows. I believe it is always safe to do this, but there may be some Windows-specific edge case I'm missing. I'll also note that I get this error when building, although the build succeeds and the library seems to work:If all is well it'd be nice to get a point release with this fix, since I don't think there's a way to build this package on Windows otherwise (disregarding any Cygwin trickery).