Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix handling of extra-libs, extra-includes in Setup.hs #53

Merged
merged 2 commits into from Mar 5, 2018

Conversation

rdnetto
Copy link
Contributor

@rdnetto rdnetto commented Mar 2, 2018

This PR modifies Setup.hs to correctly handle --extra-include-dirs and --extra-lib-dirs.
Failing to do so breaks compilation under Nix.

@tmcdonell tmcdonell merged commit 6fa06b7 into tmcdonell:master Mar 5, 2018
@tmcdonell
Copy link
Owner

tmcdonell commented Mar 5, 2018

Thanks!

Question: has nix not worked this entire time (I thought it did?) or did something change recently in the nix world?

@tmcdonell
Copy link
Owner

Do any of the other cuda packages need this fix as well?

@rdnetto
Copy link
Contributor Author

rdnetto commented Mar 5, 2018

Question: has nix not worked this entire time (I thought it did?) or did something change recently in the nix world?

I suspect it hasn't been working this entire time - without the extra-libs, there would have been no way to find nvidia-x11.
I only started using Nix recently though, so this is pure conjecture.

Do any of the other cuda packages need this fix as well?

With this change, all of cuda's dependency now build under Nix. (Admittedly this may simply be because they have no C dependencies). I haven't been able to compile accelerate* under Nix yet, but that's for a different reason (Nix doesn't contain the latest versions of each library, and the ones it does don't satisfy the version bounds). If further changes are required, I'll be happy to raise a PR for them once I figure out what they are.

@tmcdonell
Copy link
Owner

Sounds good to me. Uploaded as cuda-0.9.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants