Avoid a deadlock in DBusConnection.HandleMessage #113
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DBusConnection.HandleMessage
will invokeTaskCompletionSource<Message>.SetResult
. This can cause the continuation of that task completion source to be invoked synchronously. This can cause the calling code (i.e. code which invoked a D-Bus method using Tmds.DBus) to delay or block the execution of theHandleMessage
method and, as such, the entire D-Bus message loop.Specify
TaskCreationOptions.RunContinuationsAsynchronously
when creating theTaskCompletionSource
helps avoid this issue.