Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Do not duplicate ReadAsync in DataAvailable. #167

Merged
merged 1 commit into from
Jul 13, 2022

Conversation

madewokherd
Copy link
Contributor

Fixes #164.

@tmds
Copy link
Owner

tmds commented Jul 7, 2022

Can you change the PR to:

Replace what is in theif (errno == EAGAIN) branch with:

if (!_socket.ReceiveAsync(_waitForData))
{
    DataAvailable(null, null);
}

@madewokherd
Copy link
Contributor Author

That does seem to work, and it makes sense to me. I'll update the PR.

@tmds tmds merged commit df3d058 into tmds:main Jul 13, 2022
@tmds
Copy link
Owner

tmds commented Jul 13, 2022

Thank you, @madewokherd!

@AdrianEggenberger
Copy link

Thank you both for finding and fixing this issue. The effects of this issue gave me an uncomfortable feeling in the last weeks as I had no clue where to search for a reason for the missing events. Very glad that it has been found!

@madewokherd madewokherd deleted the dataavailable_race branch July 13, 2022 15:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Long running application sometimes stops to get watched DBUS changes
3 participants