Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

<<do>> tags not processing comments properly. #300

Closed
leahiel opened this issue May 11, 2024 · 1 comment
Closed

<<do>> tags not processing comments properly. #300

leahiel opened this issue May 11, 2024 · 1 comment
Labels
bug Something isn't working

Comments

@leahiel
Copy link

leahiel commented May 11, 2024

Version
Publicly Available Alpha: SugarCube v2.37.0-alpha.19+10193
Most Recent Build Available: SugarCube v2.37.0-alpha.20+1
I did not test the backported <<do>> <<redo>> macro set for ≤ v2.36.1

Describe the bug.
Text within <<do>> macros may not be parsing comments properly. For instance, having <<do>> within a comment will trigger an error if used within a <<do>> macro.

To Reproduce:

:: APassageName
/* <<do>> */
<<do>>
    No errors from comment outside of do macro!
<</do>>

<br><br>

<<do>>
    Oh look, errors!
    /* <<do>> */
<</do>>

image

Expected behavior.
No error.

Project details.

  • SugarCube Version: SugarCube v2.37.0-alpha.19+10193 and SugarCube v2.37.0-alpha.20+1
  • Included Add-ons: None
  • Included Libraries: None
  • Compiler & Version: Latest, Tweego, version 2.1.1+81d1d71 (2020-02-25T07:09:26Z) [windows/amd64]

Desktop details.

  • OS & Version: Windows 11
  • Browser & Version: Latest version of Firefox, Chrome and Edge
@leahiel leahiel added the bug Something isn't working label May 11, 2024
@tmedwards
Copy link
Owner

That is an undocumented "feature" of the v2 macro parser that isn't limited to the <<do>> macro and is not going to be fixed in the v2.x.x series.

@tmedwards tmedwards closed this as not planned Won't fix, can't repro, duplicate, stale May 13, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working
Projects
None yet
Development

No branches or pull requests

2 participants