Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add support for CancellationToken in IFlurlResponse asynchronous methods #817

Closed
Prologh opened this issue Apr 8, 2024 · 1 comment
Closed

Comments

@Prologh
Copy link
Contributor

Prologh commented Apr 8, 2024

Hi, will you be willing to add support for cancellation token in asynchronous methods of IFlurlResponse? Alternatively, accept a PR that adds that support? It can be a non-breaking change with those cancellation tokens having default value, similar to SendAsync() method from IFlurlRequest.

I'd like to pass the cancellation token when reading request response, so in case of large response I can cancel it, not wait till the end. With this change, I suspect that all Receive() extension methods should also accept cancellation token, since they directly use IFlurlResponse methods.

Let me know your thoughts about that.

@Prologh
Copy link
Contributor Author

Prologh commented Apr 8, 2024

I guess I just created a duplicate of #711. I'm closing this one.

@Prologh Prologh closed this as completed Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

1 participant