[multitouch] Produce separate events for every pressed or removed touch point #143
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…ch point Also emit touchend event before touchmove when handling Qt's touchEvent. This makes the test suite http://w3c-test.org/touch-events/ pass all cases.
|
|
||
| // Produce separate event for every pressed touch points | ||
| Q_FOREACH (int id, pressedIds) { | ||
| MultiTouchInput meventStart(MultiTouchInput::MULTITOUCH_START, timeStamp, TimeStamp(), 0); |
There was a problem hiding this comment.
While the meventStart existed previously I'd take a change now and add commit on top for renaming it.
Maybe something like multiTouchInputStart instead of meventStart to improve code readability.
Similarly for meventEnd and meventMove
|
Renamed MultiTouchInput variables and exploited std::less. Also added commit to stop processing an event if it's a touch cancel event. |
|
Generally LGTM. Kind of reminds me of what QtWebEngine is doing for touch events. |
|
LGTM! |
tmeshkova
added a commit
that referenced
this pull request
Jul 28, 2015
[multitouch] Produce separate events for every pressed or removed touch point
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Also emit touchend event before touchmove when handling Qt's touchEvent.
This makes the test suite http://w3c-test.org/touch-events/ pass all
cases and improves pinching at m.here.com.