Moving to scroll decorators #61
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 20, 2014 13:24
In future, we can control vertical and horizontal scroll decorator independently based on move direction.
|
See also: sailfishos/sailfish-browser#18 |
|
LGTM |
|
Could you provide fix for qmldeclarative browser too ? you can build it on desktop if needed |
|
Sure, will update declarative browser. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains two commits. First one merges two scroll decorator classes into one and second one adds moving property to the scroll decorator. Currently we're moving scroll decorators only when root frame moves. QMozScrollDecorator::moving is true also when root frame moves.
In future, we can control vertical and horizontal scroll
decorator independently based on move direction.