Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Mangrove dryad vines in deep water are invisible and burn as if on ground #463

Open
tmewett opened this issue Apr 16, 2022 · 3 comments
Open
Labels
bug Something isn't working priority

Comments

@tmewett
Copy link
Owner

tmewett commented Apr 16, 2022

This creates a very large amount of steam, seemingly from nowhere.

@pender
Copy link
Contributor

pender commented Apr 22, 2022

I suspect this can be fixed by adding (DFF_BLOCKED_BY_OTHER_LAYERS) to the dungeon feature flags for the Dryad grass DF, although it may prevent dryad grass from spawning on shallow water too.

@brturn
Copy link
Contributor

brturn commented Feb 6, 2023

While looking into #372, I also looked at this issue.

Verified the bug - the burning vines generate an enormous amount of steam (fills an entire dungeon level if doors don't block it).

DFF_BLOCKED_BY_OTHER_LAYERS does not fix the issue, it still spawns over deep water. Interestingly, after burning it also leaves grass over the water.

Looked at how/why things can burn over water. Appears that the "priority" field of a floorTileType determines whether a feature ignites or extinguishes (where lower priority is stronger). G_VINE has a very strong priority (19) and can catch fire, while water is in the range of 40-55 and can extinguish it. So it will always ignite even when it is over water.

Adjusting the priority to 58 gave a more reasonable burn behavior (does not ignite over water), but also places the vines 'under' the water layer. Not sure what the desired behavior is.

@tmewett
Copy link
Owner Author

tmewett commented Feb 27, 2023

Appears that the "priority" field of a floorTileType determines whether a feature ignites or extinguishes

I wonder if this is needed anywhere, or if we can do the check without priority?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug Something isn't working priority
Projects
None yet
Development

No branches or pull requests

3 participants