Move letters off the grid to make text more readable #656
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Nathan-Fenner
commented
Jan 21, 2024
| dest.x += offsetForEnd / 2; | ||
| } | ||
|
|
||
| // int diff = abs(tile->foreRed - tile->backRed) + abs(tile->foreGreen - tile->backGreen) + abs(tile->foreBlue - tile->backBlue); |
There was a problem hiding this comment.
- This is some debugging logic, I'll remove it
Closed
tmewett
reviewed
Mar 23, 2024
Comment on lines
+1288
to
+1289
| /// 1 : Left-aligned text [startColumn must be set] | ||
| /// 2 : Middle-aligned text [startColumn and endColumn must be set] |
There was a problem hiding this comment.
Suggested change
| /// 1 : Left-aligned text [startColumn must be set] | |
| /// 2 : Middle-aligned text [startColumn and endColumn must be set] | |
| /// 1 : Left-aligned text [firstColumn must be set] | |
| /// 2 : Middle-aligned text [firstColumn and lastColumn must be set] |
| /// 0 : Normal terminal output | ||
| /// 1 : Left-aligned text [startColumn must be set] | ||
| /// 2 : Middle-aligned text [startColumn and endColumn must be set] | ||
| int8_t mode; |
There was a problem hiding this comment.
Yep, that would be a good idea, I was being lazy.
I'll fix this after I rebase the PR to fix the conflicts.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR augments the
cellDisplayBufferstruct with a new field,CellTextInfo textInfothat tracks information about the text qualities of the cell. When drawing text to the screen,textInfo.textModeis set to a non-zero value:The platform can read this information, and adjust the placement of letters to make text more readable:
As shown in the screenshot above, most interfaces and log messages now make use of this fancier text-printing info.
I think I've ironed out all of the bugs, but it's possible that there's still some screens which display incorrectly.
Platforms must be modified to accept the extra
CellTextInfoparameter in theirplotCharimplementation - though it can simply be ignored if the platform doesn't want to or can't support moving the letters around. The actual display logic change is pretty small - seetiles.cfor what the platform actually does to make use of this new metadata.