New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vision, aggression, attack rewrite #686

Open

brturn wants to merge 4 commits into tmewett:master from brturn:vision-agression-attack-rewrite

+291 −101

Contributor

brturn commented May 18, 2024

This is an experimental PR to fix #540.
Curious to get some eyes on it.

Fixes whip/pike/flail/axe attacking invisible but revealed enemies.
Full rewrite of the core mechanics for monster vision, aggression, and willingness to attack.
I've verified that they can work as replacements for the original code, with minor tweaks.

Because the new functions consistently apply the 'laws' of Brogue, they also introduce some new behaviors:

Player will attack entranced monsters when bumping.
Confused player will lunge-attack allies.
Confused player will spear-attack allies.
Confused player will axe-sweep allies.
Confused player will flail allies when passing.

Similar changes in behavior occur when replacing the original code in other areas of the codebase.

brturn added 4 commits

May 12, 2024 22:38


          WIP: rewrite vision, agression, and attacking logic

32756e8


          Code cleanup, fix bumping

4a165c9


          More code cleanup

a1b2282


          Cleanup

1e01b12

brturn mentioned this pull request

Fix for whip/pike attack invisible but revealed enemies #540

Closed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment